NIFI-268: If processor is using deprecated annotations, should fail unit test


Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/a7b826ae
Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/a7b826ae
Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/a7b826ae

Branch: refs/heads/develop
Commit: a7b826ae20588705868749390187852f2c05e0ff
Parents: 54f3476
Author: Mark Payne <[email protected]>
Authored: Mon Mar 23 15:39:53 2015 -0400
Committer: Mark Payne <[email protected]>
Committed: Mon Mar 23 15:39:53 2015 -0400

----------------------------------------------------------------------
 .../java/org/apache/nifi/util/StandardProcessorTestRunner.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/a7b826ae/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java
----------------------------------------------------------------------
diff --git 
a/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java
 
b/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java
index f3fd3e8..8d691dd 100644
--- 
a/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java
+++ 
b/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java
@@ -137,14 +137,14 @@ public class StandardProcessorTestRunner implements 
TestRunner {
     private static void detectDeprecatedAnnotations(final Processor processor) 
{
         for ( final Class<? extends Annotation> annotationClass : 
deprecatedTypeAnnotations ) {
             if ( processor.getClass().isAnnotationPresent(annotationClass) ) {
-                logger.warn("Processor is using deprecated Annotation " + 
annotationClass.getCanonicalName());
+                Assert.fail("Processor is using deprecated Annotation " + 
annotationClass.getCanonicalName());
             }
         }
         
         for ( final Class<? extends Annotation> annotationClass : 
deprecatedMethodAnnotations ) {
             for ( final Method method : processor.getClass().getMethods() ) {
                 if ( method.isAnnotationPresent(annotationClass) ) {
-                    logger.warn("Processor is using deprecated Annotation " + 
annotationClass.getCanonicalName() + " for method " + method);
+                    Assert.fail("Processor is using deprecated Annotation " + 
annotationClass.getCanonicalName() + " for method " + method);
                 }
             }
         }

Reply via email to