[
https://issues.apache.org/jira/browse/NIFI-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378087#comment-14378087
]
Dan Bress commented on NIFI-460:
--------------------------------
[~markap14] Working on this ticket now. How does this apply to Controller
Services? Should they use {{.identifiesControllerService}} as well? I noticed
this popping up in:
-
[DistributedMapCacheClientService|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-client-service/src/main/java/org/apache/nifi/distributed/cache/client/DistributedMapCacheClientService.java#L67]
-
[DistributedSetCacheClientService|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-client-service/src/main/java/org/apache/nifi/distributed/cache/client/DistributedSetCacheClientService.java#L67]
-
[DistributedCacheServer|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-services/nifi-distributed-cache-services-bundle/nifi-distributed-cache-server/src/main/java/org/apache/nifi/distributed/cache/server/DistributedCacheServer.java#L48]
What do you think about deprecating the
{{StandardValidator.createControllerServiceExistsValidator}} and push people
towards {{.identifiesControllerService}}?
> Invoke HTTP should use new way of using ControllerService
> ---------------------------------------------------------
>
> Key: NIFI-460
> URL: https://issues.apache.org/jira/browse/NIFI-460
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 0.1.0
> Reporter: Dan Bress
> Assignee: Dan Bress
> Priority: Minor
> Labels: beginner
>
> Invoke HTTP currently uses the old way of identifying a controller service.
> In its case SSLContextService. It should use the new way like GetHTTP does.
> The old way is:
> {code}
> .addValidator(StandardValidators.createControllerServiceExistsValidator(SSLContextService.class))
> {code}
> [Link to
> code|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L266]
> The new way is:
> {code}
> .identifiesControllerService(SSLContextService.class)
> {code}
> [Link to
> code|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java#L229]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
