[ 
https://issues.apache.org/jira/browse/NIFI-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520498#comment-14520498
 ] 

Aldrin Piri commented on NIFI-374:
----------------------------------

Build is fine.  Code looks good.  +1

> EncryptContent not handling exceptions properly
> -----------------------------------------------
>
>                 Key: NIFI-374
>                 URL: https://issues.apache.org/jira/browse/NIFI-374
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Witt
>            Assignee: Mark Payne
>            Priority: Minor
>              Labels: beginner
>             Fix For: 0.1.0
>
>         Attachments: 0001-NIFI-374-Route-ProcessException-s-to-failure.patch
>
>
> EncryptContent does not handle exceptions properly.  It has a callback which 
> converts checked exceptions to RuntimeException (ProcessException) but then 
> it just lets them fly.  The problem with that is that data which will never 
> succeed (because it cannot be decompressed for example) is always being 
> rolledback.  It should go to failure.  So we need the processor to handle 
> exceptions.
> https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EncryptContent.java#L166-L175
> https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/EncryptContent.java#L256-L260



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to