[
https://issues.apache.org/jira/browse/NIFI-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520799#comment-14520799
]
Sean Busbey commented on NIFI-561:
----------------------------------
btw, patch was generated after application of NIFI-144, so it'll go easier if
that patch lands first.
> FileBasedClusterNodeFirewallTest should rely on JUnit / Maven norms for test
> files.
> -----------------------------------------------------------------------------------
>
> Key: NIFI-561
> URL: https://issues.apache.org/jira/browse/NIFI-561
> Project: Apache NiFi
> Issue Type: Task
> Components: Core Framework
> Affects Versions: 0.0.1
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Minor
> Attachments: NIFI-561.1.patch.txt
>
>
> Right now FileBasedClusterNodeFirewallTest sets up its own test directory and
> reads test files directly out of hte source tree.
> These are both undesirable
> * setting up a temp directory in java.io.tmp manually makes more work when we
> could use a junit tempdirectory (it also makes it more likely that we'll mess
> up parallel builds)
> * reading out of the source tree prevents adding in maven rules that process
> the test resources before the test (as opposed to reading them out of
> target/classes, where teh test resource handler will put the finished
> products).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
