NIFI-463 cleaning up code
Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/93f246a3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/93f246a3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/93f246a3 Branch: refs/heads/develop Commit: 93f246a3fdda70458b6d3b9fad362b7b4ce03d25 Parents: d9a86e5 Author: danbress <[email protected]> Authored: Tue Mar 24 14:50:21 2015 -0400 Committer: danbress <[email protected]> Committed: Fri May 1 07:54:43 2015 -0400 ---------------------------------------------------------------------- .../documentation/html/HtmlDocumentationWriter.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/93f246a3/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/html/HtmlDocumentationWriter.java ---------------------------------------------------------------------- diff --git a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/html/HtmlDocumentationWriter.java b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/html/HtmlDocumentationWriter.java index 70cd513..684261a 100644 --- a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/html/HtmlDocumentationWriter.java +++ b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/main/java/org/apache/nifi/documentation/html/HtmlDocumentationWriter.java @@ -544,8 +544,8 @@ public class HtmlDocumentationWriter implements DocumentationWriter { } /** - * Uses the {@link ExtensionManager} to discover any controller service that implement the controller service - * API. + * Uses the {@link ExtensionManager} to discover any {@link ControllerService} implementations that implement a specific + * ControllerService API. * * @param parent the controller service API * @return a list of controller services that implement the controller service API @@ -553,10 +553,14 @@ public class HtmlDocumentationWriter implements DocumentationWriter { private List<Class<? extends ControllerService>> lookupControllerServiceImpls( final Class<? extends ControllerService> parent) { - final Set<Class> controllerServices = ExtensionManager.getExtensions(ControllerService.class); - final List<Class<? extends ControllerService>> implementations = new ArrayList<>(); - for (Class<? extends ControllerService> controllerServiceClass : controllerServices) { + + // first get all ControllerService implementations + final Set<Class> controllerServices = ExtensionManager.getExtensions(ControllerService.class); + + // then iterate over all controller services looking for any that is a child of the parent + // ControllerService API that was passed in as a parameter + for (final Class<? extends ControllerService> controllerServiceClass : controllerServices) { if (parent.isAssignableFrom(controllerServiceClass)) { implementations.add(controllerServiceClass); }
