[
https://issues.apache.org/jira/browse/NIFI-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568275#comment-14568275
]
Dan Bress edited comment on NIFI-633 at 6/2/15 2:46 PM:
--------------------------------------------------------
[~mcgilman] and [~markap14] I noticed some funky dependency business going on.
Mainly nifi-framework-core-api depending on nifi-runtime. This felt wrong to
me. So I removed that dependency, and then added two dependencies that were
coming in transitively. I rebuilt from scratch and gave the app a quick once
over and behavior seemed OK.
Do you agree with these changes that are somewhat unrelated to this ticket, but
fix the cyclic dependency issue Matt noted? Please advise.
You can see the specific changes in [this
commit|https://github.com/apache/incubator-nifi/commit/c0570fb395ebfeb2ccaac1a29ed6c31a835ca325]
was (Author: danbress):
[~mcgilman] and [~markap14] I noticed some funky dependency business going on.
Mainly nifi-framework-core-api depending on nifi-runtime. This felt wrong to
me. So I removed that dependency, and then added two dependencies that were
coming in transitively. I rebuilt from scratch and gave the app a quick once
over and behavior seemed OK.
Do you agree with this changes that are somewhat unrelated to this ticket, but
fix the cyclic dependency issue Matt noted? Please advise.
You can see the specific changes in [this
commit|https://github.com/apache/incubator-nifi/commit/c0570fb395ebfeb2ccaac1a29ed6c31a835ca325]
> Documentation Generation: Logger
> --------------------------------
>
> Key: NIFI-633
> URL: https://issues.apache.org/jira/browse/NIFI-633
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.1.0
> Reporter: Matt Gilman
> Assignee: Dan Bress
> Priority: Minor
> Fix For: 0.1.1
>
> Attachments: 0001-Squashed-commit-of-the-following.patch
>
>
> During the documentation generation, the processor is created and
> initialized. During initialization the processor is given a mock
> ProcessorInitializationContext which returns null when calling getLogger().
> If a processor attempts to log anything without verifying the logger is not
> null, a NPE is thrown and documentation generation fails.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
