[
https://issues.apache.org/jira/browse/NIFI-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573088#comment-14573088
]
ASF subversion and git services commented on NIFI-659:
------------------------------------------------------
Commit fb75a4ba692ec834e470fc89de24bdd483439796 in incubator-nifi's branch
refs/heads/develop from [~joewitt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=fb75a4b ]
NIFI-659 updated all instances of child overrides to combine their excludes and
parents
> rat-plugin needs to be configured to exclude child and parent items
> -------------------------------------------------------------------
>
> Key: NIFI-659
> URL: https://issues.apache.org/jira/browse/NIFI-659
> Project: Apache NiFi
> Issue Type: Task
> Components: Tools and Build
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Fix For: 0.2.0
>
> Attachments: NIFI-659.patch
>
>
> Presently when doing the proper -Pcontrib-check on patches and such we can
> run into issues with modules that implement their own excludes above and
> beyond what the nifi-parent excludes. This is due to how the configuration
> override/merge/append mechanism works in Maven 3. What we really want it to
> do is 'append' to the child's list whatever was in the parents list. So for
> example:
> {code:xml}
> <plugin>
> <groupId>org.apache.rat</groupId>
> <artifactId>apache-rat-plugin</artifactId>
> <configuration>
> <excludes>
> <exclude>src/test/resources/conf/0bytes.xml</exclude>
>
> <exclude>src/test/resources/conf/termination-only.xml</exclude>
> <exclude>src/test/resources/hello.txt</exclude>
>
> <exclude>src/test/resources/old-swap-file.swap</exclude>
> </excludes>
> </configuration>
> </plugin>
> {code}
> would work as we really want it to if it were
> {code:xml}
> <plugin>
> <groupId>org.apache.rat</groupId>
> <artifactId>apache-rat-plugin</artifactId>
> <configuration>
> <excludes combine.children="append">
> <exclude>src/test/resources/conf/0bytes.xml</exclude>
>
> <exclude>src/test/resources/conf/termination-only.xml</exclude>
> <exclude>src/test/resources/hello.txt</exclude>
>
> <exclude>src/test/resources/old-swap-file.swap</exclude>
> </excludes>
> </configuration>
> </plugin>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
