[
https://issues.apache.org/jira/browse/NIFI-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574724#comment-14574724
]
Joseph Witt commented on NIFI-41:
---------------------------------
Mark: Code has been applied locally and is presently running through
contrib-check. Comments based on reading the code itself.. My initial thought
was that acknowledgement size information was a bit of a leaky abstraction
issue. However, I see that acknowledgement is actually a well established part
of this FlowFileQueue data structure. So, good. I do observe that many of
these methods lack javadocs and the class itself does too. Those should
probably be addressed at some point. So in reviewing this change i'll put that
arguably unrelated detail aside.
Ok full clean build went well. It is very non-trivial to test this edge case
at runtime so i have not done that. I have started the app and done several
relationship modifications while running/stopped/etc.. and all appears to be
fine still.
+1
> Shoud not be able to change destination of Connection if component has its
> FlowFiles
> ------------------------------------------------------------------------------------
>
> Key: NIFI-41
> URL: https://issues.apache.org/jira/browse/NIFI-41
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Joseph Witt
> Assignee: Mark Payne
> Fix For: 0.2.0
>
> Attachments:
> 0001-NIFI-41-Don-t-allow-destination-fo-connection-to-cha.patch
>
>
> When updating connection's target, should check FLowFileQueue's
> Unacknowledged FlowFile count
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
