[ 
https://issues.apache.org/jira/browse/NIFI-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580998#comment-14580998
 ] 

ASF GitHub Bot commented on NIFI-589:
-------------------------------------

Github user joey commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/51#issuecomment-110892315
  
    @rdblue and @joewitt See the latest. I think this addresses all of the 
Ryan's feedback. I do have one open question:
    
    Currently I'm stopping the Sinks and Sources in an `@OnUnscheduled` 
callback, but I'm not sure if that's the right place to do it. I'm not sure 
about the intention of the API generally, but the `TestRunner#run()` method 
will call `@OnUnscheduled` callbacks immediately after the first call to 
`Processor#onTrigger()`. That means that effectively only a single 
`onTrigger()` happens in any of my tests. Should this be delayed until an 
`@OnStopped` callback?


> Add processors that can run Apache Flume sources/sinks
> ------------------------------------------------------
>
>                 Key: NIFI-589
>                 URL: https://issues.apache.org/jira/browse/NIFI-589
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>    Affects Versions: 0.1.0
>            Reporter: Joey Echeverria
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to