[ 
https://issues.apache.org/jira/browse/NIFI-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589249#comment-14589249
 ] 

Matt Gilman commented on NIFI-454:
----------------------------------

Changes look good. Verify build and test cases. +1

gilman$ mvn -version
Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 
2014-08-11T16:58:10-04:00)
Maven home: /usr/local/Cellar/maven/3.2.3/libexec
Java version: 1.8.0_25, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_25.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.10.3", arch: "x86_64", family: "mac"

> Distributed cache server unit tests should use random ports
> -----------------------------------------------------------
>
>                 Key: NIFI-454
>                 URL: https://issues.apache.org/jira/browse/NIFI-454
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions, Tools and Build
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>              Labels: beginner
>             Fix For: 0.2.0
>
>         Attachments: 
> 0001-NIFI-454-Use-random-ports-instead-of-specific-ports-.patch
>
>
> the distributed-map-cache-server (and maybe the distributed-set-cache-server) 
> have unit tests that start the servers but don't set the port. The tests 
> should be updated to set the port to 0 so that it will use a random port. 
> This means that the service implementation will also need to expose the port 
> that it's listening on so that the unit tests can know the port.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to