[ 
https://issues.apache.org/jira/browse/NIFI-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591158#comment-14591158
 ] 

Joseph Witt commented on NIFI-547:
----------------------------------

+1 with the following caveats:

I have not executed the patch against a running system to validate that the 
behavior before and after is improved.  My review is visual inspection only.  I 
recommend that we do not have version declarations for dependencies this low on 
the pom tree.  IMHO it is better to have the dependency management of 
nifi/pom.xml call out the dependency versions and then let the lower level 
modules just declare the dependency without the version.  This makes upgrading 
version dependencies easier and helps reduce the needless use of non compatible 
versions in nars.  Now nars protect this from being an actual problem but by 
following this guidance it helps us keep our house in order.

> Data Viewer: Better support for Unicode characters
> --------------------------------------------------
>
>                 Key: NIFI-547
>                 URL: https://issues.apache.org/jira/browse/NIFI-547
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>            Reporter: Matt Gilman
>            Assignee: Matt Gilman
>            Priority: Minor
>             Fix For: 0.2.0
>
>         Attachments: 0001-NIFI-547.patch
>
>
> Content with unicode characters (\u0000) are not rendered correctly and 
> potentially break the formatted view. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to