[
https://issues.apache.org/jira/browse/NIFI-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593737#comment-14593737
]
Dan Bress commented on NIFI-704:
--------------------------------
I noticed this when trying to extend BinFiles. I would call
"TestRunner.run(25)" and found that most of the time, runs 2-25 were called
after OnUnscheduled, which BinFiles checks for and returns immediately. I did
not want this to happen. I think the right place to fix this is in the
StandardProcessorTestRunner. I'll try and submit a failing unit test later.
> StandardProcessorTestRunner should allow you to wait before calling
> OnUnScheduled methods
> -----------------------------------------------------------------------------------------
>
> Key: NIFI-704
> URL: https://issues.apache.org/jira/browse/NIFI-704
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
> Affects Versions: 0.1.0
> Reporter: Dan Bress
> Priority: Minor
>
> [StandardProcessorTestRunner does not
> wait|https://github.com/apache/incubator-nifi/blob/develop/nifi/nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java#L208-L210]
> for the processor 'run' calls to finish before invoking the @OnUnscheduled
> methods. This may result in the Processor 'run' calls acting weird, because
> @OnUnscheduled has been called.
> Notice that
> [ExecutorService.shutdown()|http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ExecutorService.html#shutdown%28%29]
> says _This method does not wait for previously submitted tasks to complete
> execution. Use awaitTermination to do that._
> I would suggest that the StandardProcessorTestRunner either always wait for
> the processor run calls to finish, or let you specify an amount of time to
> wait for them to finish.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
