[ 
https://issues.apache.org/jira/browse/NIFI-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596549#comment-14596549
 ] 

Matt Gilman commented on NIFI-80:
---------------------------------

+1

Build is good.
Contrib check is good.
Verified truncation feature.

My only comment is that it may be misleading for users that are expecting the 
property {code}nifi.provenance.repository.max.attribute.length{code} to save on 
disk usage when using the persistent provenance repository. The intent of this 
feature is to limit memory usage when attributes may be lengthy. The properties 
file contains a comment that indicates that truncation happens when loading 
events from the repository. This should be sufficient and I don't think any 
further actions are necessary at this time.

> When provenance repo retrieves an event that has attributes > some threshold, 
> truncate the value
> ------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-80
>                 URL: https://issues.apache.org/jira/browse/NIFI-80
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Joseph Witt
>            Assignee: Mark Payne
>             Fix For: 0.2.0
>
>         Attachments: 
> 0001-NIFI-80-Truncate-attribute-values-that-exceed-some-t.patch
>
>
> If we have a lot of large attribute keys and/or values we can have memory 
> issues interacting with flow files or their provenance events, etc..  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to