[
https://issues.apache.org/jira/browse/NIFI-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597770#comment-14597770
]
Mark Payne commented on NIFI-716:
---------------------------------
Dan,
All good ideas. We actually already have a ticket, NIFI-34, that deals with
having the Mock Framework detect a lot of these types of things. Please check
out that ticket and add anything to it that you think is appropriate for the
mock framework to do.
re: forgetting to do something vs. a valid case of intentionally not doing
it... I think we could handle that by having an override for
TestRunners.newTestRunner(Processor proc) that allows us to pass in something
like: TestRunners.newTestRunner(Processor proc, CodeQualityChecks checks) and
then have some sort of builder that allows us to turn specific checks on/off.
That way, we can explicitly tell the test runner that we know we did something
different than usual, but we want it that way.
> Framework allows you to define two properties with the same name
> ----------------------------------------------------------------
>
> Key: NIFI-716
> URL: https://issues.apache.org/jira/browse/NIFI-716
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.1.0
> Reporter: Dan Bress
> Priority: Minor
> Labels: beginner, newbie
>
> If you are lazy and copy and paste a PropertyDescriptor and forget to change
> the value assigned to name(), the framework(test or regular) does not detect
> this and proceeds happily.
> It would be great if this situation was detected as soon as possible, and
> either mark the processor as invalid, or fail to consider it as a possible
> processor.
> This applies to Processors, ControllerServices and ReportingTasks
> Example
> {code}
> public static final PropertyDescriptor MIN_SIZE = new
> PropertyDescriptor.Builder()
> .name("Minimum Group Size")
> .description("The minimum size of for the bundle")
> .required(true)
> .defaultValue("0 B")
> .addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
> .build();
> public static final PropertyDescriptor MAX_SIZE = new
> PropertyDescriptor.Builder()
> .name("Minimum Group Size")
> .description("The maximum size for the bundle. If not specified, there is no
> maximum.")
> .required(false)
> .addValidator(StandardValidators.DATA_SIZE_VALIDATOR)
> .build();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
