[
https://issues.apache.org/jira/browse/NIFI-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597835#comment-14597835
]
Mark Payne commented on NIFI-674:
---------------------------------
I reviewed the changes to the FileSystemRepository. Code looks good. Build
works with checkstyle and all unit tests. All appears to work properly (and
better than before). +1
> FileSystemRepository should not create new threads in its constructor
> ---------------------------------------------------------------------
>
> Key: NIFI-674
> URL: https://issues.apache.org/jira/browse/NIFI-674
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 0.1.0
> Reporter: Mark Payne
> Assignee: Dan Bress
> Priority: Minor
> Fix For: 0.2.0
>
>
> FileSystemRepository creates two different ExecutorServices in its
> constructor. This is problematic because we iterate over the ServiceLoader,
> which creates an instance of FileSystemRepository and then throws it away.
> Instead, these executors should be created in the initialize method.
> It should also be documented in the ContentRepository interface that any time
> that initialize() is called, it is expected that the shutdown() method will
> also be called, as this is where we can cleanup the things that we did during
> initialization. This was the intended lifecycle but never was clearly
> documented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
