[
https://issues.apache.org/jira/browse/NIFI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606499#comment-14606499
]
ASF GitHub Bot commented on NIFI-738:
-------------------------------------
Github user joewitt commented on the pull request:
https://github.com/apache/incubator-nifi/pull/69#issuecomment-116860033
```
ests run: 4, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.339 sec
<<< FAILURE! - in org.apache.nifi.processors.kite.TestJSONToAvroProcessor
testBasicConversion(org.apache.nifi.processors.kite.TestJSONToAvroProcessor)
Time elapsed: 0.325 sec <<< FAILURE!
org.junit.ComparisonFailure: Should accumulate error messages
expected:<...annot convert field [id: Cannot convert to long: "120V", Cannot
convert field color: Cannot convert to string: 15.23 (1 similar failure)]> but
was:<...annot convert field [color: Cannot convert to string: 15.23 (1 similar
failure), Cannot convert field id: Cannot convert to long: "120V"]>
at org.junit.Assert.assertEquals(Assert.java:115)
at
org.apache.nifi.processors.kite.TestJSONToAvroProcessor.testBasicConversion(TestJSONToAvroProcessor.java:83)
testOnlyErrors(org.apache.nifi.processors.kite.TestJSONToAvroProcessor)
Time elapsed: 0.004 sec <<< FAILURE!
org.junit.ComparisonFailure: Should set an error message expected:<...annot
convert field [id: Cannot convert to long: "120V", Cannot convert field color:
Cannot convert to string: 15.23 (1 similar failure)]> but was:<...annot convert
field [color: Cannot convert to string: 15.23 (1 similar failure), Cannot
convert field id: Cannot convert to long: "120V"]>
at org.junit.Assert.assertEquals(Assert.java:115)
at
org.apache.nifi.processors.kite.TestJSONToAvroProcessor.testOnlyErrors(TestJSONToAvroProcessor.java:107)
Running org.apache.nifi.processors.kite.TestKiteProcessorsCluster
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in
org.apache.nifi.processors.kite.TestKiteProcessorsCluster
Running org.apache.nifi.processors.kite.TestKiteStorageProcessor
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0 sec - in
org.apache.nifi.processors.kite.TestKiteStorageProcessor
Results :
Failed tests:
TestJSONToAvroProcessor.testBasicConversion:83 Should accumulate error
messages expected:<...annot convert field [id: Cannot convert to long: "120V",
Cannot convert field color: Cannot convert to string: 15.23 (1 similar
failure)]> but was:<...annot convert field [color: Cannot convert to string:
15.23 (1 similar failure), Cannot convert field id: Cannot convert to long:
"120V"]>
TestJSONToAvroProcessor.testOnlyErrors:107 Should set an error message
expected:<...annot convert field [id: Cannot convert to long: "120V", Cannot
convert field color: Cannot convert to string: 15.23 (1 similar failure)]> but
was:<...annot convert field [color: Cannot convert to string: 15.23 (1 similar
failure), Cannot convert field id: Cannot convert to long: "120V"]>
```
Ryan i had trouble running the unit tests. It is possible I've now
returned the wrong branch favor but I think I'm building against exactly what
you sent. Can you confirm?
> Do not write conversion error messages to flow file content
> -----------------------------------------------------------
>
> Key: NIFI-738
> URL: https://issues.apache.org/jira/browse/NIFI-738
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 0.1.0
> Reporter: Ryan Blue
> Assignee: Ryan Blue
> Fix For: 0.2.0
>
>
> NIFI-551 extended the error handling provided by the ConvertJSONToAvro
> processor, but wrote error messages as the content of a file sent on the
> failure relationship. I think the right thing to do is to output the bad
> records as the file content and put the error messages in the outgoing
> attributes.
> NIFI-551 wasn't included in 0.1.0, so changing this behavior is safe.
> Consequently, I'd like to get this fix into 0.2.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
