xiaoxiang781216 commented on a change in pull request #179: macOS support for sim URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372242597
########## File path: arch/sim/src/sim/up_setjmp32.S ########## @@ -46,8 +46,12 @@ #ifdef __CYGWIN__ # define SYMBOL(s) _##s #else +#ifdef __ELF__ Review comment: The logic is wrong, should it be #ifndef? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
