xiaoxiang781216 commented on a change in pull request #181: Fix an inverted logic in the following commit. URL: https://github.com/apache/incubator-nuttx/pull/181#discussion_r372541950
########## File path: arch/sim/src/sim/up_setjmp32.S ########## @@ -47,9 +47,9 @@ # define SYMBOL(s) _##s #else #ifdef __ELF__ -# define SYMBOL(s) _##s -#else # define SYMBOL(s) s +#else +# define SYMBOL(s) _##s #endif #endif Review comment: Yes, the separation is better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
