patacongo commented on a change in pull request #37: examples: hello: Show CPU 
index when running in SMP mode
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/37#discussion_r372894731
 
 

 ##########
 File path: examples/hello/hello_main.c
 ##########
 @@ -50,6 +54,12 @@
 
 int main(int argc, FAR char *argv[])
 {
+#ifdef CONFIG_SMP
+  uint32_t cpu = up_cpu_index();
 
 Review comment:
   Neither arevproper posix interfaces and neither show be called or implemted 
in you space.  This must be reverted.
   
   It will also break any SMP PROTECTED or kernel mode build.
   
   You could make an exteneion to prctl().  The at least uses a Linux-like 
interface and will not break other builds.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to