xiaoxiang781216 commented on a change in pull request #210: Reimplement sim uart on top of serial driver framework URL: https://github.com/apache/incubator-nuttx/pull/210#discussion_r375119697
########## File path: arch/sim/src/sim/up_devconsole.c ########## @@ -163,7 +289,20 @@ static int devconsole_poll(FAR struct file *filep, FAR struct pollfd *fds, void up_devconsole(void) { - register_driver("/dev/console", &devconsole_fops, 0666, NULL); + uart_register("/dev/console", &g_devconsole_dev); + uart_register("/dev/ttyS0", &g_devconsole_dev); +} + +/**************************************************************************** + * Name: up_devconsole Review comment: FIx. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services