patacongo commented on a change in pull request #270: Small I2C fixups URL: https://github.com/apache/incubator-nuttx/pull/270#discussion_r378983337
########## File path: drivers/i2c/Kconfig ########## @@ -54,3 +50,7 @@ config I2CMULTIPLEXER_PCA9540BDP endmenu # I2C Multiplexer Support endif + +config ARCH_HAVE_I2CRESET Review comment: The reason is that ARCH_HAVE_I2CRESET is selected unconditionally in all architecture configurations that support I2C reset. That is correct, advertising that an architecture supports a feature is conditional. CONFIG_I2C is completely unnecessary to enable architecture I2C support. If conditions are added to ARCH_HAVE_I2CRESET, the errors referring to unmet dependencies will be generated on all configurations that enabled architecture-specific I2C support but don't need CONFIG_I2C. This same change was added a few weeks ago and this resulted in several new errors in build testing and had to be fixed by moving ARCH_HAVE_I2CRESET outside of I2C. It must be that way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
