xiaoxiang781216 commented on a change in pull request #69: mksymtab.sh: Avoid 
using find -executable
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/69#discussion_r379452683
 
 

 ##########
 File path: examples/elf/tests/mksymtab.sh
 ##########
 @@ -22,7 +22,7 @@ fi
 # Extract all of the undefined symbols from the ELF files and create a
 # list of sorted, unique undefined variable names.
 
-varlist=`find ${dir} -executable -type f | xargs nm | fgrep ' U ' | sed -e 
"s/^[ ]*//g" | cut -d' ' -f2 | sort | uniq`
 
 Review comment:
   Maybe we can modify the code to use the same name, I don't see any benefit 
that each project have the different symbol table name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to