patacongo commented on a change in pull request #279: tiva/lm3s6965-ek: Add
CONFIG_BOARD_LATE_INITIALIZE
URL: https://github.com/apache/incubator-nuttx/pull/279#discussion_r379521040
##########
File path: boards/arm/tiva/lm3s6965-ek/src/lm_appinit.c
##########
@@ -152,6 +153,9 @@ int board_app_initialize(uintptr_t arg)
mcinfo("Successfully bound SPI port %d to MMC/SD slot %d\n",
CONFIG_NSH_MMCSDSPIPORTNO, CONFIG_NSH_MMCSDSLOTNO);
+#endif
Review comment:
I am not going to hold this up any longer. But this means that the logic
about the #ifndef CONFIG_BOARD_LATE_INITIALIZE will not be execute when
initialization is done via board_late_initialize. I don't think you really
want that asymmetry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
