yamt commented on a change in pull request #81: do ARLOCK things a bit differently URL: https://github.com/apache/incubator-nuttx-apps/pull/81#discussion_r382384440
########## File path: Make.defs ########## @@ -99,9 +99,13 @@ define REGISTER endef endif -define ARLOCK - $(Q) flock .arlock $(call ARCHIVE, $1, $(2)) -endef +# Workaround for concurrent execution to the same library (libapps) +ifeq ($(CONFIG_HOST_MACOS),y) +# macOS doesn't have flock. Use shlock instead. +AR := $(APPDIR)/tools/flock.sh $(APPDIR)/.arlock $(AR) +else +AR := flock $(APPDIR)/.arlock $(AR) Review comment: i checked some of ARCHIVE but they all seem calling AR one way or another. you are right this doesn't work if ARCHIVE does something completely different. i suspect it isn't the case though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
