patacongo commented on issue #370: net: socket: Introduce net_clear_sinzero() URL: https://github.com/apache/incubator-nuttx/pull/370#issuecomment-590671700 It is difficult to review changes from differences. It looks to me like you are setting sin_zero only on values of sockaddr_in returned from the OS. In that case, ignore my preceding rant. The change is OK. The creator/initialize of the sockaddr structure, whether the application or the OS must initialize sin_zero. Never the receiver of sin_zero. I retract my previous statements in opposition to the change based on the understanding.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
