adamfeuer commented on a change in pull request #372: SAMA5 GMAC driver
improvements: prevent txtimeout from always firing and fix txbuffer leak during
high-volume sends
URL: https://github.com/apache/incubator-nuttx/pull/372#discussion_r383664593
##########
File path: arch/arm/src/sama5/sam_gmac.c
##########
@@ -1642,14 +1657,13 @@ static int sam_gmac_interrupt(int irq, void *context,
FAR void *arg)
* one to this bit.
*/
- tsr = sam_getreg(priv, SAM_GMAC_TSR_OFFSET);
+ tsr = sam_getreg(priv, SAM_GMAC_TSR);
Review comment:
This is the fix for the txtimeout always firing; the old code had the wrong
register address here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services