xiaoxiang781216 commented on a change in pull request #95: Avoid calling ARCHIVE in multiple places (again) URL: https://github.com/apache/incubator-nuttx-apps/pull/95#discussion_r384263687
########## File path: Application.mk ########## @@ -163,6 +157,9 @@ endif install:: $(PROGLIST) +show-objs: Review comment: for module build, this is two step process: 1.All source files(except main) compile and archieve into libapps like builtin. 2.Main soruce file compile and link with LDLIBS to form the final image. The difference from kernel mode and other mode is LDLIBS content: 1.Kernel mode: LDLIBS has all userspace library(libc, libproxy, libapps...), so the binary is totally self contain. 2.Other mode: LDLIBS just contain libapps, so the binary will link with the base image to resovle the symbol at in runtime. But, I see your patch remove libapps from LDLIBS: https://github.com/apache/incubator-nuttx-apps/pull/83/files ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
