xiaoxiang781216 commented on a change in pull request #102: Revert "Remove
libapps.a from LDLIBS"
URL:
https://github.com/apache/incubator-nuttx-apps/pull/102#discussion_r384278838
##########
File path: Make.defs
##########
@@ -152,3 +152,11 @@ endif
CFLAGS += ${shell $(INCDIR) $(INCDIROPT) "$(CC)" "$(APPDIR)$(DELIM)include"}
CXXFLAGS += ${shell $(INCDIR) $(INCDIROPT) "$(CC)" "$(APPDIR)$(DELIM)include"}
+
+ifneq ($(CONFIG_BUILD_KERNEL),y)
Review comment:
Need remove ifneq ($(CONFIG_BUILD_KERNEL),y), libapps.a is also needed for
kernel build. Actually, the original code don't have this guard, which is added
by my team member:(
commit b5cfd9344439c9aeb25c539431a034bdca6b5154
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
