xiaoxiang781216 commented on issue #382: syslog/file: Remove syslog_dev_uninitialize in syslog_file_channel URL: https://github.com/apache/incubator-nuttx/pull/382#issuecomment-591931624 > Does not even compile, or am I missing an interim patch? > > ``` > syslog/syslog_device.c: In function 'syslog_dev_outputready': > syslog/syslog_device.c:268:15: error: void value not ignored as it ought to be > ret = syslog_dev_initialize(g_syslog_dev.sl_devpath, > ^ > syslog/syslog_device.c: At top level: > syslog/syslog_device.c:316:5: error: conflicting types for 'syslog_dev_initialize' > int syslog_dev_initialize(FAR const char *devpath, int oflags, int mode) > ^~~~~~~~~~~~~~~~~~~~~ > In file included from syslog/syslog_device.c:59:0: > syslog/syslog.h:99:6: note: previous declaration of 'syslog_dev_initialize' was here > void syslog_dev_initialize(FAR const char *devpath, int oflags, int mode); > ^~~~~~~~~~~~~~~~~~~~~ > syslog/syslog_device.c:416:6: error: conflicting types for 'syslog_dev_uninitialize' > void syslog_dev_uninitialize(void) > ^~~~~~~~~~~~~~~~~~~~~~~ > In file included from syslog/syslog_device.c:59:0: > syslog/syslog.h:122:5: note: previous declaration of 'syslog_dev_uninitialize' was here > int syslog_dev_uninitialize(void); > ^~~~~~~~~~~~~~~~~~~~~~~ > Makefile:126: recipe for target 'syslog_device.o' failed > make[1]: *** [syslog_device.o] Error 1 > make[1]: Leaving directory '/home/jni/u/yard/workarea/nuttx/drivers' > tools/LibTargets.mk:104: recipe for target 'drivers/libdrivers.a' failed > ``` Sorry, I change the wrong function prototype, how about the new patch? It is hard to test my patch local since there isn't official config enabled this option.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
