patacongo commented on issue #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid… URL: https://github.com/apache/incubator-nuttx/pull/453#issuecomment-595766041 Both false negatives and false positives must be avoided. When I change nxstyle, I verify by: 1) Testing the error was fixed in test file, then 2) Verify that other behaviors were not broken like: FILELIST=`find sched -name *.c` for file in $FILELIST; do echo "=== $file =============================================" tools/nxstyle.exe -m 4 $file done I use sched/ because it is probably the best formatted code in the system. I run this with nxstyle BEFORE the change then with nxstyle AFTER the change. They should be identical (unless the modified nxstyle corrects some error in the original).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
