patacongo commented on a change in pull request #458: stm32h7: support SDRAM via FMC peripherial URL: https://github.com/apache/incubator-nuttx/pull/458#discussion_r388939275
########## File path: arch/arm/src/stm32h7/stm32_fmc.c ########## @@ -39,40 +39,387 @@ #include <nuttx/config.h> +#if defined(CONFIG_STM32H7_FMC) + #include "stm32.h" -#if defined(CONFIG_STM32H7_FMC) +#include <debug.h> + +//#include "stm32_fmc.h" +//#include "hardware/stm32_pinmap.h" +//#include "stm32_gpio.h" +//#include "stm32_rcc.h" Review comment: Use of commented out code and any use of C++ comments is forbidden by the coding standard. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
