xiaoxiang781216 commented on a change in pull request #457: Build System:
Resolve CPU-specific logic in common build files
URL: https://github.com/apache/incubator-nuttx/pull/457#discussion_r389032275
##########
File path: boards/arm/cxd56xx/spresense/scripts/Make.defs
##########
@@ -35,6 +35,7 @@
include ${TOPDIR}/.config
include ${TOPDIR}/tools/Config.mk
+include ${TOPDIR}/boards/arm/cxd56xx/scripts/cxd56xx_Config.mk
Review comment:
How about remove cxd56xx_ prefix? because:
1.The path already have cxd56xx
2.Align with tools/Config.mk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
