davids5 commented on a change in pull request #594: Tools refine
URL: https://github.com/apache/incubator-nuttx/pull/594#discussion_r395654841
##########
File path: tools/Makefile.unix
##########
@@ -565,17 +547,15 @@ do_gconfig: dirlinks apps_preconfig
gconfig: do_gconfig clean_context
-do_savedefconfig: dirlinks apps_preconfig
-
-savedefconfig: do_savedefconfig
+savedefconfig: dirlinks apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --savedefconfig
defconfig.tmp Kconfig
$(Q) sed -i -e "/CONFIG_APPS_DIR=/d" defconfig.tmp
$(Q) grep "CONFIG_ARCH=" .config >> defconfig.tmp
$(Q) grep "^CONFIG_ARCH_CHIP_" .config >> defconfig.tmp; true
- $(Q) grep "^CONFIG_ARCH_CHIP=" .config >> defconfig.tmp; true
- $(Q) grep "CONFIG_ARCH_BOARD=" .config && grep "CONFIG_ARCH_BOARD="
.config >> defconfig.tmp; true
- $(Q) grep "^CONFIG_ARCH_CUSTOM" .config && grep "^CONFIG_ARCH_CUSTOM"
.config >> defconfig.tmp; true
- $(Q) grep "^CONFIG_ARCH_BOARD_CUSTOM=" .config && grep
"^CONFIG_ARCH_BOARD_CUSTOM" .config >> defconfig.tmp; true
+ $(Q) grep "CONFIG_ARCH_CHIP=" .config >> defconfig.tmp; true
+ $(Q) grep "CONFIG_ARCH_BOARD=" .config >> defconfig.tmp; true
+ $(Q) grep "^CONFIG_ARCH_CUSTOM" .config >> defconfig.tmp; true
+ $(Q) grep "^CONFIG_ARCH_BOARD_CUSTOM" .config >> defconfig.tmp; true
Review comment:
Oh OK.
hmm - good to know you have it working - when we do an uptake I will figure
out the cause and fix it.
The other bug was a real problem because it breaks every defconfig on an
uptake. Thank you for fixing it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
