patacongo commented on issue #604: Initial support for the Infineon XMC4700 
Relax board
URL: https://github.com/apache/incubator-nuttx/pull/604#issuecomment-602209788
 
 
   This kind of logic is very common in architecure specific code:
   
   - Set up some definitions, then
   - include some architecture specific code
   
   You will see this a lot in arch/xyz/include and arch/src/xyz/hardware 
directories.
   
   I added the check to nxstyle that is causing the problem.  My intention was 
to assure that people provide the "Included Files" section header.  So the 
error would file if that section is not present.
   
   Ideally, then all #included should be in that "Included Files" section.  But 
there are exceptions where it makes sense to relax this requirement.  So as 
this one and, I suspect, several others.
   
   I don't know of any way to programmatically "relax" the requirement other 
than inspecting the nxstyle complaint and then making a good, informed 
engineering decision.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to