xiaoxiang781216 commented on a change in pull request #599: sim: Add a CLI
option to override vpnkit socket
URL: https://github.com/apache/incubator-nuttx/pull/599#discussion_r396183049
##########
File path: arch/sim/src/sim/up_head.c
##########
@@ -77,6 +78,8 @@ static char g_logbuffer[4096];
int main(int argc, char **argv, char **envp)
{
+ process_cli_options(argc, argv);
Review comment:
> maybe. a command line option is more convenient for me though.
>
> may i move the command line option part to a separate PR? i haven't
expected it was this controversial.
Sure, thanks for your support.
BTW, how about we use environment variable which is more easier than command
line for extension.
1.Command line is normally use for the frequent used option
2.Environment variable is normallhy used for the seldom changed option
And unix domain socket path is the second case, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
