patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403771526
########## File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c ########## @@ -0,0 +1,175 @@ +/**************************************************************************** + * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c + * + * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt <[email protected]> + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: Review comment: Ahh... talking with Abdelatif, I missunderstood the question. I am the copyright holder and the old SDMMC code and do give my approval to change the license header to the Apache 2.0 license header cited above. The one with the PX4 copyright must also have an Apache 2.0 header to be considered. BTW: The current version of my original SDMMC file does now have an Apache header and also includes requires changes that you do not have in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
