patacongo commented on a change in pull request #789: Add RISC-V FPU support URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408331748
########## File path: arch/risc-v/src/common/up_initialize.c ########## @@ -113,6 +116,13 @@ void up_initialize(void) up_addregion(); + /* Initialize the idle task stack info */ + + idle = this_task(); /* It should be idle task */ + idle->stack_alloc_ptr = _END_BSS; + idle->adj_stack_ptr = (FAR void *)g_idle_topstack; + idle->adj_stack_size = CONFIG_IDLETHREAD_STACKSIZE; + Review comment: It would be nice to generalize this for all architectures. There is description in top-level TODO list of how this might be done in nx_start(). Putting this logic in each up_initialize() is probably fine too since we really cannot handle faults until up_initailize() is called. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
