patacongo commented on issue #185: nsh improvement URL: https://github.com/apache/incubator-nuttx-apps/pull/185#issuecomment-615875439 > @patacongo - Do you see any harm in renaming sh to `source` and `.` No, that seems appropriate to me. In that case, if 'sh' were implemented as a builtin task, it would just execute the nsh command 'source' or '.' in the context of the spawned task. Then it becomes sh since it has no effect on the parent task. > > I would also add the concern of stack nesting and fragmentation to the list. > > Please contrast the existing implementation to the proposed one in terms of stack nesting and fragmentation when the /etc/rind.d/rcS has > > `sh ./l1` and l1 has `sh .l2` > > From a small platform with the goal of having a clean set of scripts, that really just needs `sh` to include the as if it were one file.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
