btashton commented on a change in pull request #904:
URL: https://github.com/apache/incubator-nuttx/pull/904#discussion_r418906527
##########
File path: arch/x86_64/src/intel64/intel64_lowsetup.c
##########
@@ -64,16 +77,16 @@ void up_lowsetup(void)
/* Setup pointers for accessing Page table and GDT in high address */
- pdpt = &pdpt_low + X86_64_LOAD_OFFSET;
- pd = &pd_low + X86_64_LOAD_OFFSET;
- pt = &pt_low + X86_64_LOAD_OFFSET;
+ pdpt = (uint64_t *)((uint64_t)&pdpt_low + X86_64_LOAD_OFFSET);
+ pd = (uint64_t *)((uint64_t)&pd_low + X86_64_LOAD_OFFSET);
+ pt = (uint64_t *)((uint64_t)&pt_low + X86_64_LOAD_OFFSET);
- ist64 = (struct ist_s *)((void *)&ist64_low + X86_64_LOAD_OFFSET);
- gdt64 = (struct gdt_entry_s *)((void *)&gdt64_low + X86_64_LOAD_OFFSET);
+ ist64 = (struct ist_s *)((uint64_t)&ist64_low +
X86_64_LOAD_OFFSET);
+ gdt64 = (struct gdt_entry_s *)((uint64_t)&gdt64_low +
X86_64_LOAD_OFFSET);
Review comment:
@sonicyang I misunderstood what you were saying. You are right I have
update to use the pointer type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
