xiaoxiang781216 commented on a change in pull request #230:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/230#discussion_r420218871



##########
File path: .github/workflows/build.yml
##########
@@ -162,17 +109,38 @@ jobs:
           retry_wait_seconds: 10
           command: docker pull 
docker.pkg.github.com/apache/incubator-nuttx-testing/nuttx-ci-linux
 
-      - name: Export NuttX Repo SHA
-        run:  echo "::set-env name=nuttx_sha::`git -C sources/nuttx rev-parse 
HEAD`"
-      - name: Refresh Git Credentials
+      - uses: actions/download-artifact@v2
+        with:
+          name: gitrefs
+          path: gitrefs-rt/
+      - name: Export Repo Refs

Review comment:
       All steps have a name but "uses: actions/download-artifact@v2" don't 
have. so I suppose that it's one step from line 118 to line 123, and should 
order like this:
         - name: Export Repo Refs
         - uses: actions/download-artifact@v2
           with:
             name: gitrefs
             path: gitrefs-rt/
           run: source gitrefs-rt/gitenv.sh




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to