xiaoxiang781216 commented on a change in pull request #977:
URL: https://github.com/apache/incubator-nuttx/pull/977#discussion_r420345572
##########
File path: arch/arm/include/tls.h
##########
@@ -97,11 +82,15 @@ static inline uint32_t up_getsp(void)
*
****************************************************************************/
+#ifdef CONFIG_TLS_ALIGNED
static inline FAR struct tls_info_s *up_tls_info(void)
{
DEBUGASSERT(!up_interrupt_context());
return TLS_INFO((uintptr_t)up_getsp());
Review comment:
Yes, but sim up_getsp can call __builtin_frame_address for us, right?
The problem is that:
1.up_getsp is implemented by most arch
2.the aglined stack allocation also support by several arch
3.but tls.h is just implemented on arm/sim
or1k is one of case we need modify too, some arch(riscv/xtensa) implment the
partial tls which is better to remove or enhance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
