patacongo opened a new issue #246:
URL: https://github.com/apache/incubator-nuttx-apps/issues/246


   Several examples (and other things under apps/) make illegal calls to 
`romdisk_register()`.  This both violates the portable POSIX OS interface and 
makes these applications un-usable in PROTECTED and KERNEL build modes.
   
   Non-compliant examples include:
   
       examples/bastest, examples/elf, examples/module,
       examples/nxflat, examples/posix_spawn, examples/romfs,
       examples/sotest, examples/thttpd, examples/unionfs
   
   These examples are simple demos and, hence, you could argue that it is not 
so bad that they violate the interface for the purpose of demonstration 
(although they do set a bad example because of this).
   
   These examples should, of course, use boardctl(BOARDIOC_ROMDISK)  to create 
the ROM disk instead of calling `romdisk_register() `directly.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to