jlaitine commented on a change in pull request #1037:
URL: https://github.com/apache/incubator-nuttx/pull/1037#discussion_r424947772
##########
File path: arch/arm/src/stm32h7/Make.defs
##########
@@ -137,11 +137,6 @@ CHIP_CSRCS += stm32_adc.c
endif
ifeq ($(CONFIG_STM32H7_BBSRAM),y)
-ifeq ($(CONFIG_ARMV7M_DCACHE),y)
Review comment:
This was really added twice; the mpu is already included on line 95:
ifeq ($(CONFIG_ARM_MPU),y)
CMN_CSRCS += arm_mpu.c
endif
This is exactly my configuration: CONFIG_STM32H7_BBSRAM=y,
CONFIG_ARMV7M_DCACHE=y, CONFIG_ARM_MPU=y.
This configuration would pull in the arm_mpu.c twice, which causes
warnings/errors in compilation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
