raiden00pl commented on a change in pull request #1051:
URL: https://github.com/apache/incubator-nuttx/pull/1051#discussion_r426132456
##########
File path: arch/arm/src/stm32/Kconfig
##########
@@ -1129,15 +1129,80 @@ config ARCH_CHIP_STM32F469N
select STM32_STM32F469
select STM32_HAVE_ETHMAC
+config ARCH_CHIP_STM32G474C
Review comment:
It seems to me that this is not correct. You should use chip names from
[here](https://www.st.com/content/ccc/fragment/product_related/line_information/line_level_diagram/group0/cc/a2/82/c1/1b/2a/45/35/stm32g4x4_line_ln2130/files/stm32g4x4_line_ln2130.jpg/_jcr_content/translations/en.stm32g4x4_line_ln2130.jpg)
(eg. STM32G474**CE**, STM32G474**CC** ... not STM32G474**C**)
Each chip version should be a single entry in the "STM32 Chip Selection"
choice menu.
Also I don't think that we need a distinction between LQFP/UFQFPN and
LQFP/BGA packages.
This does'nt affect OS in any way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
