patacongo commented on pull request #1079: URL: https://github.com/apache/incubator-nuttx/pull/1079#issuecomment-631401833
> > In past conversation you had told me that readability was more important than line length and that long lines were OK in arch headers. The code base reflected that. > > I have no recollection of that in the past. But we cut a lot of corners in the past that we no longer do. @davids5 I think I know what this is about. Header files do typically have longer lines than C source files. But that doesn't make excessively long lines more acceptable in header files. There have been changes in nxstyle from several months ago that you may not be aware of. The old nxstyle used a fixed, default line width of 78 (unless you overrode that with the -m option). But that logic has been relaced. It now determines the line width dynamically using the width of the block comment "rulers." So a long line error means that a line has extended beyond the rulers. That should be reported as an error regardless of the file type. I don't think this effects the readability of the header files unless people cram too much garbage in the right hand comments. Then the readability is bad in any case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
