xiaoxiang781216 commented on a change in pull request #1088:
URL: https://github.com/apache/incubator-nuttx/pull/1088#discussion_r427977026



##########
File path: Makefile
##########
@@ -41,9 +41,18 @@
 #   make -f tools/Makefile.win
 #
 
--include .config
+ifeq ($(wildcard .config),)

Review comment:
       is it enough to only check .config? I can add more code to check 
Make.defs but which make Makefile a little bit hard to read. Make.defs and 
.config appear at the same in most case. If something go to wrong, include 
Make.defs will stop immediately and report the problem clearly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to