pkarashchenko commented on code in PR #11338: URL: https://github.com/apache/nuttx/pull/11338#discussion_r1419524902
########## arch/xtensa/src/esp32/esp32_spiflash.c: ########## @@ -79,6 +79,19 @@ #define SPI_FLASH_ENCRYPT_MIN_SIZE (16) +#define IBUS1_PAGE_BASE IROM0_PAGES_START +#define IBUS1_PAGE_ADRR SOC_IROM_MASK_LOW +#define IBUS1_PAGE_START (IBUS1_PAGE_BASE + 13) Review Comment: Does 13 have a special meaning? I mean is it worth of a separate define? ########## arch/xtensa/src/esp32/esp32_spiflash.c: ########## @@ -79,6 +79,19 @@ #define SPI_FLASH_ENCRYPT_MIN_SIZE (16) +#define IBUS1_PAGE_BASE IROM0_PAGES_START +#define IBUS1_PAGE_ADRR SOC_IROM_MASK_LOW +#define IBUS1_PAGE_START (IBUS1_PAGE_BASE + 13) +#define IBUS1_PAGE_END (IBUS1_PAGE_BASE + 64) Review Comment: Is 64 here for `SPI_FLASH_READ_BUF_SIZE`? Or it has some other meaning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
