Re: [PR] driver/net/lan9250: Add LAN9250 driver(SPI and QSPI mode) [nuttx]

[via GitHub]

donghengqaz commented on code in PR #11339:
URL: https://github.com/apache/nuttx/pull/11339#discussion_r1419864097


##########
drivers/net/Kconfig:
##########
@@ -428,6 +428,69 @@ config NET_W5500_NINTERFACES
 
 endif # W5500
 
+menuconfig NET_LAN9250
+       bool "Microchip LAN9250 support"
+       default n
+       select SPI
+       select ARCH_HAVE_NETDEV_STATISTICS
+       ---help---
+               Enable LAN9250 SPI Ethernet driver.
+
+if NET_LAN9250
+
+choice LAN9250_INTERFACE
+       prompt "Select interface"
+       default LAN9250_SPI
+       ---help---
+               Select LAN9250 interface: SPI(4-line) or SQI(6-line).
+
+config LAN9250_SPI
+       bool "SPI"
+
+config LAN9250_SQI

Review Comment:
   In the document of LAN9250, the manufacturer calls this SQI:
   
   
![企业微信截图_17020022608644](https://github.com/apache/nuttx/assets/13296299/b7c38ac7-9049-4e74-ac20-7e0dc5ad07db)
   
   So I think we can keep using this name.



##########
drivers/net/Kconfig:
##########
@@ -428,6 +428,69 @@ config NET_W5500_NINTERFACES
 
 endif # W5500
 
+menuconfig NET_LAN9250
+       bool "Microchip LAN9250 support"
+       default n
+       select SPI
+       select ARCH_HAVE_NETDEV_STATISTICS
+       ---help---
+               Enable LAN9250 SPI Ethernet driver.
+
+if NET_LAN9250
+
+choice LAN9250_INTERFACE
+       prompt "Select interface"
+       default LAN9250_SPI
+       ---help---
+               Select LAN9250 interface: SPI(4-line) or SQI(6-line).
+
+config LAN9250_SPI
+       bool "SPI"
+
+config LAN9250_SQI

Review Comment:
   In the document of LAN9250, the manufacturer calls this SQI:
   
   
![企业微信截图_17020022608644](https://github.com/apache/nuttx/assets/13296299/b7c38ac7-9049-4e74-ac20-7e0dc5ad07db)
   
   So I think we can keep using this name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org