Rdk-T commented on code in PR #11415: URL: https://github.com/apache/nuttx/pull/11415#discussion_r1430455595
########## tools/toolchain.cmake.export: ########## @@ -1,5 +1,6 @@ set(CMAKE_SYSTEM_NAME Generic) set(CMAKE_SYSTEM_VERSION 1) +set(NUTTX 1) Review Comment: Usually CMake variables are uppercase but it is possible to mix uppercase and lower. What do you prefer ? (follow CMake style or follow NuttX style ?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
