tmedicci commented on PR #11425: URL: https://github.com/apache/nuttx/pull/11425#issuecomment-1864388541
> > > @tmedicci why not try this tool #11348 to optimize the stack usage in the common case? It's always the last resort to increase the stack size. > > > > > > Hi @xiaoxiang781216 , that is a good tool to help development (I didn't know about it, thanks)! But we are already having problems with insufficient stack size for the init thread (which, for these `defconfig`s are the NSH task), so that's why we are increasing it (please note that we are changing only the init task stack size, not the default value for the task's stack size). > > Yes, I notice that, but it's always good to try our best to ensure the common used program(e.g. nsh) work with the default stack size(2KB). If the default program stack size isn't suitable anymore, it's better to change the default value in Kconfig instead modifying each defconfig one by one. I got it, but the NSH task (with some of its commands) requires more stack size than the default 2KB. That's not true for most of the applications and 2KB is sufficient, so I prefer not to overspread the stack change and let it restricted only to the init task (the NSH stack). Either way, changing the default value would require a change to the `DEFAULT_TASK_STACKSIZE` config (I'm not considering changing the Kconfig because it is a system-wide value), so it would still reflect on each `defconfig`, right? (Am I missing something here?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
